-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] feat(slack): apm-server (backport #13307) #13344
Conversation
* feat(slack): apm-server * fix name * Apply suggestions from code review (cherry picked from commit 055c3a5) # Conflicts: # .github/workflows/benchmarks.yml # .github/workflows/run-minor-release.yml # .github/workflows/run-patch-release.yml # .github/workflows/smoke-tests-schedule.yml
Cherry-pick of 055c3a5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@@ -0,0 +1,233 @@ | |||
name: benchmarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why add this ? We don't run benchmarks for 7.17 so I'm not sure we need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how mergify works when there is an automated backport, and includes the conflict
label:
In this particular case, .github/workflows/benchmarks.yml
was not backported originally in the past, but since it was changes among some other things in #13307, when backporting it does create the file from scratch with the conflict
label.
We can delete it or keep it - it won't run for 7.17
at all, schedule
only works for the default branch, in this particular case main
.
@Mergifyio update |
✅ Branch has been successfully updated |
Motivation/summary
No more vault access but GitHub secrets
Need to support
thread-timestamp
Checklist
For functional changes, consider:
How to test these changes
Related issues
This is an automatic backport of pull request #13307 done by [Mergify](https://mergify.com).