-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go-docappender to v2 #13155
Upgrade go-docappender to v2 #13155
Conversation
This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
NOTE: |
[float] | ||
==== Bug fixes | ||
|
||
- Avoid data race due to reuse of `bytes.Buffer` in ES bulk requests {pull}13155[13155] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For reviewers] I have added changelog entries to APM-Server for go-docappender fixes so that they can be tested and documented. Let me know if this doesn't sound like a good idea.
Motivation/summary
go-docappender/v2
fixes a crucial bug with data race: elastic/go-docappender#162It also has some other fixes though they don't apply to apm-server since apm-server doesn't have document retries enabled:
In addition, it also exposes a new metric for elasticsearch flushed bytes: elastic/go-docappender#161
Checklist
- [ ] Documentation has been updatedHow to test these changes
elasticsearch.flushed.uncompressed.bytes
metric.Related issues
N/A