Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove -buildmode=pie #12757

Merged
merged 6 commits into from
May 8, 2024
Merged

feat: remove -buildmode=pie #12757

merged 6 commits into from
May 8, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Mar 1, 2024

Motivation/summary

Makes apm-server a statically linked binary. This is needed to support running apm-server in minimal environments (distroless, alpine, chainguard static, etc.)

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • make apm-server
  • file apm-server

Related issues

Closes #12670

@kruskall kruskall requested a review from a team as a code owner March 1, 2024 20:57
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 1, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 1, 2024
@kruskall kruskall enabled auto-merge (squash) May 8, 2024 10:18
@kruskall kruskall disabled auto-merge May 8, 2024 10:22
@kruskall kruskall enabled auto-merge (squash) May 8, 2024 11:17
@kruskall kruskall disabled auto-merge May 8, 2024 11:20
@kruskall kruskall enabled auto-merge (squash) May 8, 2024 12:15
@kruskall kruskall merged commit 15c0723 into elastic:main May 8, 2024
9 checks passed
@kruskall kruskall deleted the feat/remove-pie branch May 8, 2024 14:39
@kruskall
Copy link
Member Author

kruskall commented Jun 9, 2024

@Mergifyio backport 8.14

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 9, 2024 •
edited
Loading

backport 8.14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 9, 2024
@kruskall @mergify
feat: remove -buildmode=pie (#12757)
27aa267 
(cherry picked from commit 15c0723)
@mergify mergify bot mentioned this pull request Jun 9, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Jun 9, 2024
@mergify @kruskall
feat: remove -buildmode=pie (#12757) (#13371)
fa3b32f 
(cherry picked from commit 15c0723)

Co-authored-by: kruskall <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apm-server binary is not statically linked
2 participants
@kruskall @axw