Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-async-handling #12386

Merged
merged 12 commits into from
Jan 15, 2024
Merged

remove-async-handling #12386

merged 12 commits into from
Jan 15, 2024

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jan 10, 2024

Motivation/summary

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Copy link
Contributor

mergify bot commented Jan 10, 2024

This pull request does not have a backport label. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 10, 2024
@SylvainJuge SylvainJuge requested a review from kruskall January 10, 2024 14:43
@SylvainJuge SylvainJuge mentioned this pull request Jan 10, 2024
4 tasks
@kruskall kruskall marked this pull request as ready for review January 15, 2024 14:03
@kruskall kruskall requested a review from a team as a code owner January 15, 2024 14:03
@kruskall kruskall requested a review from a team January 15, 2024 14:03
@kruskall kruskall merged commit 52849ff into elastic:main Jan 15, 2024
11 checks passed
@marclop marclop self-assigned this Mar 20, 2024
@marclop
Copy link
Contributor

marclop commented Mar 20, 2024

Verified on ESS using the latest 8.13 BC. Turned on stack monitoring and observed the request handling duration. Using async=true no longer reduces process time close to zero. Additionally, I 5x the heavy.ndjson file contents so that it contained way more events than currently available semaphore.

The expected result would've been a queue is full message. However, because the async query parameter is ignored, it's accepted and processed synchronously.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-ok v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants