-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apmpackage: prepare for move to apm-data plugin #12102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
apmpackage-updates
branch
from
November 24, 2023 06:07
fe8046f
to
d3a153a
Compare
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Nov 24, 2023
axw
force-pushed
the
apmpackage-updates
branch
from
November 24, 2023 06:29
d3a153a
to
629f585
Compare
lahsivjar
approved these changes
Nov 28, 2023
Verified with BC-2 that
|
stevejsyu
added a commit
to elastic/observability-docs
that referenced
this pull request
Sep 10, 2024
Per the PR and changelogs, the `error.custom` and `transaction.custom` fields were changed to the `flattened` type, but it does not reflect the change in this document. - PR: [#12102](elastic/apm-server#12102) - Changelogs: [APM Release Notes 8.12](https://www.elastic.co/guide/en/observability/current/apm-release-notes-8.12.html#_added_7) In addion, the documentation describes these fields as "non-indexed." In SF case 01746372, the customer reported that these fields are searchable in Discover within Kibana, indicating they may actually be indexed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-skip
Skip notification from the automated backport with mergify
test-plan
test-plan-ok
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This is a precursor to #12066.
The undocumented, best-effort 7.x migration data stream migration pipeline has been removed. To migrate, users can install an older version and perform a stepped upgrade.
We add mappings for various fields to the integration package that were previously unmapped.
The following fields are all newly mapped as
flattened
:error.custom
error.exception.attributes
error.exception.stacktrace
error.log.stacktrace
http.request.body
(always send as a JSON object with a single field,original
)http.request.env
http.request.cookies
span.message.headers
span.stacktrace
transaction.custom
transaction.message.headers
http.{request,response}.headers
have been changed fromobject
toflattened
. Even though these were mapped asobject
type, they were inheritingdynamic: false
and thus the headers never got mapped. The result of this change is headers will be returned in fields now, ashttp.request.headers: {Content-Length: ...}
. There's no change to the_source
for these fields.http.response.headers_sent
is mapped as a boolean.transaction.span_count.started
is mapped as a long for consistency withtransaction.span_count.dropped
.The following fields are mapped as
keyword
, in line with the dynamic mapping rules of the apm-data plugin's templates:span.db.instance
span.db.type
span.db.user.name
span.db.statement
span.message.body
span.message.routing_key
transaction.message.body
transaction.message.routing_key
Checklist
apmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
Related issues
#12066