feat: bump go to 1.20 #12031
Merged
feat: bump go to 1.20 #12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
reviewed
Nov 10, 2023
| @@ -375,7 +375,7 @@ func getAPIKey(client es.Client, id, name *string, validOnly, asJSON bool) error | |||
| if validOnly && (apikey.Invalidated || expiry == "expired") { | |||
| continue | |||
| } | |||
| creation := time.Unix(apikey.Creation/1000, 0).Format("2006-02-01 15:04") | |||
| creation := time.Unix(apikey.Creation/1000, 0).Format("2006-01-02 15:04") | |||
There was a problem hiding this comment.
this isn't a functional change right?
There was a problem hiding this comment.
It is in the sense it's change the log message (date format is different) but the old format is wrong and reported by the linter.
I guess we can keep it to move this PR forward.
There was a problem hiding this comment.
Nevermind, it's reported by go vet which does not have an ignore mechanism
carsonip
approved these changes
Nov 10, 2023
This reverts commit d59a13f.
carsonip
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Trying to unlock #11940
Beats bumped the go version so do the same and split it out from the beats bump PR.
Checklist
apmpackagehave been made)For functional changes, consider:
How to test these changes
Related issues