Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unified notification for smoke tests #11978

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

amannocci
Copy link
Contributor

Motivation/summary

  • Only trigger one notification for the whole GitHub Workflow instead of one per sub-workflow.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

The change has been tested here.

Related issues

@amannocci amannocci self-assigned this Oct 31, 2023
@amannocci amannocci requested a review from a team as a code owner October 31, 2023 15:02
Copy link
Contributor

mergify bot commented Oct 31, 2023

This pull request does not have a backport label. Could you fix it @amannocci? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 31, 2023
@amannocci amannocci enabled auto-merge (squash) November 2, 2023 09:20
@amannocci amannocci force-pushed the feat/unified-notification branch from 31a5bd2 to 371b746 Compare November 2, 2023 09:20
@amannocci amannocci requested a review from kruskall November 2, 2023 13:01
@amannocci amannocci force-pushed the feat/unified-notification branch from 371b746 to e22738a Compare November 2, 2023 15:49
@amannocci amannocci merged commit d701da4 into main Nov 2, 2023
7 checks passed
@amannocci amannocci deleted the feat/unified-notification branch November 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants