Fix service destination max group scaling based on memory #11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression introduced in elastic#11739 - Fix bug where code is never executed - Fix wrong log message
|
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
carsonip
added
backport-8.11
simitt
previously approved these changes
Oct 19, 2023
…com:carsonip/apm-server into fix-auto-service-destination-agg-max-groups
simitt
approved these changes
Oct 19, 2023
lahsivjar
approved these changes
Oct 20, 2023
mergify bot
added a commit
that referenced
this pull request
Oct 23, 2023
…11906) * Fix service destination max group scaling based on memory Fix regression introduced in #11739 - Fix bug where code is never executed - Fix wrong log message - Fix failing test (cherry picked from commit 791f582) Co-authored-by: Carson Ip <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
|
Tested with 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Fix regression introduced in #11739
Checklist
apmpackagehave been made)For functional changes, consider:
How to test these changes
Related issues