Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Go distributed tracing example #11854

Merged
merged 5 commits into from
Oct 18, 2023
Merged

docs: Fix Go distributed tracing example #11854

merged 5 commits into from
Oct 18, 2023

Conversation

carsonip
Copy link
Member

Motivation/summary

Fix Go distributed tracing examples docs.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 13, 2023
@carsonip carsonip requested a review from bmorelli25 October 13, 2023 21:54
@carsonip
Copy link
Member Author

This is potentially be backported very far. How far do we want to go?

@carsonip carsonip marked this pull request as ready for review October 16, 2023 22:58
@carsonip carsonip requested a review from a team as a code owner October 16, 2023 22:58
@carsonip
Copy link
Member Author

I believe this can be backported to 7.17 and 8.x without conflict.

bmorelli25
bmorelli25 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bmorelli25 bmorelli25 added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 18, 2023
@bmorelli25 bmorelli25 enabled auto-merge (squash) October 18, 2023 22:22
@bmorelli25 bmorelli25 merged commit 7e4babf into elastic:main Oct 18, 2023
5 checks passed
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@carsonip @mergify
docs: Fix Go distributed tracing example (#11854)
6105ff8 
* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)

# Conflicts:
#	docs/shared/distributed-trace-receive/distributed-trace-receive.asciidoc
@mergify mergify bot mentioned this pull request Oct 18, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@carsonip @mergify
docs: Fix Go distributed tracing example (#11854)
2d9ea9a 
* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)
@mergify mergify bot mentioned this pull request Oct 18, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@carsonip @mergify
docs: Fix Go distributed tracing example (#11854)
fd778f6 
* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)
@mergify mergify bot mentioned this pull request Oct 18, 2023
Merged
mergify bot added a commit that referenced this pull request Oct 19, 2023
@mergify @carsonip
docs: Fix Go distributed tracing example (#11854) (#11893)
31f5bea 
* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)

Co-authored-by: Carson Ip <[email protected]>
mergify bot added a commit that referenced this pull request Oct 19, 2023
@mergify @carsonip
docs: Fix Go distributed tracing example (#11854) (#11892)
18ee7a9 
* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)

Co-authored-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Oct 19, 2023
@carsonip @bmorelli25
docs: Fix Go distributed tracing example (#11854)
d0f4e1d 
* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)

# Conflicts:
#	docs/shared/distributed-trace-receive/distributed-trace-receive.asciidoc
Signed-off-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Oct 19, 2023
@mergify @carsonip @bmorelli25
[7.17] docs: Fix Go distributed tracing example (backport #11854) (#1…
887928d 
…1891)

* docs: Fix Go distributed tracing example (#11854)

* docs: Fix Go distributed tracing example

* Link to go agent v2 docs

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 7e4babf)

# Conflicts:
#	docs/shared/distributed-trace-receive/distributed-trace-receive.asciidoc
Signed-off-by: Carson Ip <[email protected]>

* Fix conflict

Signed-off-by: Carson Ip <[email protected]>

---------

Signed-off-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@axw axw axw approved these changes

Assignees
No one assigned
Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carsonip @axw @bmorelli25 @kruskall