Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump go version to 1.21.3 #11821

Merged
merged 6 commits into from
Oct 11, 2023
Merged

build: bump go version to 1.21.3 #11821

merged 6 commits into from
Oct 11, 2023

Conversation

kruskall
Copy link
Member

Motivation/summary

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@kruskall kruskall requested a review from a team as a code owner October 10, 2023 19:02
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 10, 2023
@axw axw added backport-8.11 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 11, 2023
axw
axw reviewed Oct 11, 2023
View reviewed changes
script/update_go_version.sh
Comment on lines +23 to +27
sed -i "s/toolchain go[[:digit:]]\+\(\.[[:digit:]]\+\)\{1,2\}/toolchain go$GOVERSION/" tools/go.mod
sed -i "s/toolchain go[[:digit:]]\+\(\.[[:digit:]]\+\)\{1,2\}/toolchain go$GOVERSION/" internal/glog/go.mod
sed -i "s/toolchain go[[:digit:]]\+\(\.[[:digit:]]\+\)\{1,2\}/toolchain go$GOVERSION/" go.mod
sed -i "s/toolchain go[[:digit:]]\+\(\.[[:digit:]]\+\)\{1,2\}/toolchain go$GOVERSION/" systemtest/go.mod
sed -i "s/toolchain go[[:digit:]]\+\(\.[[:digit:]]\+\)\{1,2\}/toolchain go$GOVERSION/" cmd/intake-receiver/go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably follow up by using find -name go.mod

axw
axw previously approved these changes Oct 11, 2023
View reviewed changes
axw
axw previously approved these changes Oct 11, 2023
View reviewed changes
@kruskall kruskall added the backport-8.10 Automated backport with mergify label Oct 11, 2023
@axw axw merged commit d411924 into elastic:main Oct 11, 2023
11 checks passed
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@kruskall @mergify
build: bump go version to 1.21.3 (#11821)
ea9a588 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	cmd/intake-receiver/go.mod
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	internal/glog/go.mod
#	packaging/docker/Dockerfile
#	systemtest/go.mod
#	tools/go.mod
@mergify mergify bot mentioned this pull request Oct 11, 2023
Closed
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@kruskall @mergify
build: bump go version to 1.21.3 (#11821)
40704b7 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	cmd/intake-receiver/go.mod
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	internal/glog/go.mod
#	packaging/docker/Dockerfile
#	systemtest/go.mod
#	tools/go.mod
@mergify mergify bot mentioned this pull request Oct 11, 2023
Closed
@kruskall kruskall deleted the build/bump-go branch October 11, 2023 12:46
@axw
Copy link
Member

axw commented Oct 11, 2023

@Mergifyio backport 8.10 8.11

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

backport 8.10 8.11

✅ Backports have been created

@axw axw mentioned this pull request Oct 11, 2023
Merged
@axw
Copy link
Member

axw commented Oct 11, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.10

Questions ?

Please refer to the Backport tool documentation

axw pushed a commit to axw/apm-server that referenced this pull request Oct 11, 2023
@kruskall
build: bump go version to 1.21.3 (elastic#11821)
838ef6d 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	packaging/docker/Dockerfile
#	tools/go.mod
@axw axw mentioned this pull request Oct 11, 2023
Merged
@axw
Copy link
Member

axw commented Oct 11, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Questions ?

Please refer to the Backport tool documentation

axw pushed a commit to axw/apm-server that referenced this pull request Oct 11, 2023
@kruskall
build: bump go version to 1.21.3 (elastic#11821)
66587a5 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	packaging/docker/Dockerfile
#	tools/go.mod
kruskall added a commit to axw/apm-server that referenced this pull request Oct 11, 2023
@kruskall
build: bump go version to 1.21.3 (elastic#11821)
8c26765 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	packaging/docker/Dockerfile
#	tools/go.mod
axw added a commit that referenced this pull request Oct 12, 2023
@axw @kruskall @mergify
build: bump go version to 1.21.3 (#11821) (#11827)
bc71746 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	packaging/docker/Dockerfile
#	tools/go.mod

Co-authored-by: kruskall <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
axw added a commit that referenced this pull request Oct 12, 2023
@axw @kruskall @mergify
build: bump go version to 1.21.3 (#11821) (#11828)
000e124 
* build: bump go version

* build: also bump systemtest go toolchain version

* ci: update script to also set the toolchain version

* build: bump gmux

* build: run go mod tidy

* build: generate notice file

(cherry picked from commit d411924)

# Conflicts:
#	.go-version
#	NOTICE.txt
#	docs/version.asciidoc
#	go.mod
#	go.sum
#	packaging/docker/Dockerfile
#	tools/go.mod

Co-authored-by: kruskall <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruskall @axw