Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch built-in ILM rollover policies from max_size to max_primary_shard_size #11729

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Switch built-in ILM rollover policies from max_size to max_primary_shard_size #11729

merged 1 commit into from
Oct 6, 2023

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Sep 27, 2023

Motivation/summary

In the Kibana UI, when looking at ILM policies related to apm-server, I see warnings:

Maximum index size is deprecated and will be removed in a future version. Use maximum primary shard size instead.

To avoid confusion for the end-user, I recommend that the same changes which were done in elasticsearch's default ILM policies be done for apm-server:

Related to:

Checklist

Related issues

Fixes: #11728

@rodrigc rodrigc requested a review from a team as a code owner September 27, 2023 15:46
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

This pull request does not have a backport label. Could you fix it @rodrigc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 27, 2023
kruskall
kruskall previously approved these changes Sep 27, 2023
@kruskall
Copy link
Member

For reviewers: elastic/kibana#96545

testing/smoke/lib.sh Outdated Show resolved Hide resolved
@rodrigc
Copy link
Contributor Author

rodrigc commented Sep 27, 2023

I needed to remove the EOL markers that my editor added to the json files, otherwise elastic-package would complain that the files were not formatted.

kruskall
kruskall previously approved these changes Sep 27, 2023
dmathieu
dmathieu previously approved these changes Sep 28, 2023
lahsivjar
lahsivjar previously approved these changes Oct 2, 2023
@kruskall kruskall enabled auto-merge (squash) October 5, 2023 13:23
@rodrigc rodrigc changed the title Switch built-in ILM policies to max_primary_shard_size Switch built-in ILM rollover policies from max_size to max_primary_shard_size Oct 5, 2023
auto-merge was automatically disabled October 5, 2023 15:54

Head branch was pushed to by a user without write access

@rodrigc rodrigc dismissed stale reviews from kruskall, lahsivjar, and dmathieu via 6de42d3 October 5, 2023 15:54
@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 5, 2023

I added a changelog entry to appease the elasticsearch-ci/docs workflow check

@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 5, 2023

How can I make the elasticsearch-ci/docs automation pass?
I thought that adding an entry to changelogs/head.asciidoc was enough, but looks like it is not.

@axw
Copy link
Member

axw commented Oct 6, 2023

/run elasticsearch-ci/docs

@axw
Copy link
Member

axw commented Oct 6, 2023

How can I make the elasticsearch-ci/docs automation pass?

@rodrigc the docs CI only runs for Elastic employee PRs by default for security reasons. I've prodded it into action.

@axw axw enabled auto-merge (squash) October 6, 2023 00:34
@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 6, 2023

Ah ok, thanks for clarification about the docs CI

@axw
Copy link
Member

axw commented Oct 6, 2023

@rodrigc sorry, one more hurdle: commits need to be signed. Would you please sign your commit and force push to update the branch? You can find out how to sign commits at https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification, if you're unfamiliar with that.

Remove EOL to appease elastic-package

Signed-off-by: Craig Rodrigues <[email protected]>
auto-merge was automatically disabled October 6, 2023 02:35

Head branch was pushed to by a user without write access

@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 6, 2023

OK, I followed the steps to have a verified commit

@axw
Copy link
Member

axw commented Oct 6, 2023

/run elasticsearch-ci/docs

@axw axw enabled auto-merge (squash) October 6, 2023 02:40
@axw axw merged commit 78a071e into elastic:main Oct 6, 2023
@rodrigc rodrigc deleted the max-primary-shard-size branch October 6, 2023 03:19
@axw
Copy link
Member

axw commented Oct 6, 2023

🎉 thank you @rodrigc!

@simitt
Copy link
Contributor

simitt commented Dec 19, 2023

Tested with BC 2: set policy to roll over at 9MB, ingested data and observed the rollover (not exactly at 9MB due to continous ingestion).
Screenshot 2023-12-19 at 16 14 11
Screenshot 2023-12-19 at 16 14 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-ok v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch built-in policies to .actions.rollover.max_primary_shard_size
7 participants