Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document sampling behavior on TBS storage limit reached #11663

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Sep 18, 2023

Motivation/summary

Document sampling behavior on TBS storage limit reached.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #11126

@carsonip carsonip requested a review from a team as a code owner September 18, 2023 16:28
@carsonip
Copy link
Member Author

how far should we backport this doc improvement?

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 18, 2023
@kruskall
Copy link
Member

Should we backport this ?

@carsonip carsonip added backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 20, 2023
@carsonip
Copy link
Member Author

backporting to 8.8+ since docs/configure/sampling.asciidoc only existed since 8.8.

@carsonip carsonip merged commit f33e218 into elastic:main Sep 20, 2023
5 checks passed
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)
mergify bot added a commit that referenced this pull request Sep 20, 2023
#11679)

Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)

Co-authored-by: Carson Ip <[email protected]>
mergify bot added a commit that referenced this pull request Sep 20, 2023
#11680)

Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 25, 2023
#11678)

Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the behaviour of TBS on failure to process batch
3 participants