Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add tail-based sampling common problem #11662

Merged
merged 2 commits into from
Sep 20, 2023
Merged

docs: Add tail-based sampling common problem #11662

merged 2 commits into from
Sep 20, 2023

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Sep 18, 2023 •
edited
Loading

Motivation/summary

Document TBS high memory and high disk IO common problem.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #11544

@carsonip carsonip requested a review from a team as a code owner September 18, 2023 16:18
@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 18, 2023
@carsonip
Copy link
Member Author

how far should we backport this doc improvement?

@kruskall
Copy link
Member

Should we backport this ?

@carsonip carsonip added backport-8.0 Automated backport with mergify backport-8.3 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify backport-8.0 Automated backport with mergify backport-8.3 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify labels Sep 20, 2023
@carsonip
Copy link
Member Author

only backporting to 8.8+ since the file changed significantly since 8.8.

@carsonip carsonip enabled auto-merge (squash) September 20, 2023 16:47
@kruskall
Copy link
Member

I think backporting to 8.10 might be enough since the others are not supported

@carsonip carsonip disabled auto-merge September 20, 2023 16:49
@carsonip carsonip enabled auto-merge (squash) September 20, 2023 16:55
@carsonip carsonip merged commit 1da1f38 into elastic:main Sep 20, 2023
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@carsonip @mergify
docs: Add tail-based sampling common problem (#11662)
9c1947f 
Document TBS high memory and high disk IO common problem.

(cherry picked from commit 1da1f38)
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@carsonip @mergify
docs: Add tail-based sampling common problem (#11662)
59b25e0 
Document TBS high memory and high disk IO common problem.

(cherry picked from commit 1da1f38)
This was referenced Sep 20, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@carsonip @mergify
docs: Add tail-based sampling common problem (#11662)
36ebbd8 
Document TBS high memory and high disk IO common problem.

(cherry picked from commit 1da1f38)
@mergify mergify bot mentioned this pull request Sep 20, 2023
Merged
mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify @carsonip
docs: Add tail-based sampling common problem (#11662) (#11682)
847dce5 
Document TBS high memory and high disk IO common problem.

(cherry picked from commit 1da1f38)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify @carsonip
docs: Add tail-based sampling common problem (#11662) (#11683)
771081b 
Document TBS high memory and high disk IO common problem.

(cherry picked from commit 1da1f38)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 25, 2023
@mergify @carsonip
docs: Add tail-based sampling common problem (#11662) (#11681)
a453ffa 
Document TBS high memory and high disk IO common problem.

(cherry picked from commit 1da1f38)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@carsonip carsonip mentioned this pull request Nov 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall approved these changes

@marclop marclop marclop approved these changes

Assignees
No one assigned
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document TBS common pitfalls
3 participants
@carsonip @kruskall @marclop