Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTLP benchmarking with copied telemetrygen files #58

Merged
merged 23 commits into from
Mar 26, 2024
Merged

Add OTLP benchmarking with copied telemetrygen files #58

merged 23 commits into from
Mar 26, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Feb 20, 2024 •
edited
Loading

  • Add telemetry OTLP bench to apmbench
  • Copy files from otel repo

Alternative to #55 but this does not require a fork, since a copy of the telemetrygen now lives in apm-perf. Telemetrygen is a tool in otel repo that sends otlp logs, traces and metrics: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/telemetrygen

carsonip
carsonip commented Feb 20, 2024
View reviewed changes
Copy link
Member Author

@carsonip carsonip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate copying the files from telemetrygen (slight differences: e2etest directory removed, file headers changed, go.mod and go.sum removed) but I don't see a good way to reuse the code otherwise.

internal/telemetrygen/common/config.go Outdated Show resolved Hide resolved
@carsonip carsonip requested a review from axw February 20, 2024 22:49
@carsonip carsonip requested a review from lahsivjar February 21, 2024 12:05
@carsonip carsonip marked this pull request as ready for review February 21, 2024 12:05
@carsonip carsonip requested a review from a team as a code owner February 21, 2024 12:06
@carsonip carsonip marked this pull request as draft February 21, 2024 22:10
lahsivjar
lahsivjar approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure about the license stuff though.

cmd/apmbench/main.go Show resolved Hide resolved
internal/telemetrygen/README.md Outdated Show resolved Hide resolved
internal/telemetrygen/common/config.go Show resolved Hide resolved
internal/telemetrygen/common/package_test.go
)

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL goleak

@carsonip carsonip marked this pull request as ready for review March 25, 2024 22:03
lahsivjar
lahsivjar approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carsonip carsonip merged commit a8d35be into elastic:main Mar 26, 2024
3 checks passed
@carsonip carsonip mentioned this pull request Mar 27, 2024
Closed
@simitt simitt mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahsivjar lahsivjar lahsivjar approved these changes

@axw axw axw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonip @axw @lahsivjar