Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apmbench: add protocol to loadgen config #52

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 11, 2024

Context

The MIS benchmarks are failing with:

apmbench-648… │ panic: invalid or unsupported protocol ()
apmbench-648… │ 
apmbench-648… │ goroutine 5 [running]:
apmbench-648… │ main.newEventHandler({0x0?, 0x0?}, {0xbec9d5, 0x8}, 0xc00050c050)
apmbench-648… │ 	/opt/apm-perf/cmd/apmbench/bench.go:215 +0x2c6
apmbench-648… │ main.benchmarkAgent(0x0?, 0x0?, {0xbec9d5?, 0x0?})
apmbench-648… │ 	/opt/apm-perf/cmd/apmbench/bench.go:221 +0x34
apmbench-648… │ main.BenchmarkAgentAll(0x0?, 0x0?)
apmbench-648… │ 	/opt/apm-perf/cmd/apmbench/bench.go:74 +0x25
apmbench-648… │ main.runOne.func1.1()
apmbench-648… │ 	/opt/apm-perf/cmd/apmbench/run.go:123 +0x67
apmbench-648… │ created by main.runOne.func1
apmbench-648… │ 	/opt/apm-perf/cmd/apmbench/run.go:121 +0xdb
apmbench-648… │      ┊ Scheduled       - <1s
apmbench-648… │      ┊ Initialized     - <1s
apmbench-648… │      ┊ Ready           - (…) Pending

in https://github.com/elastic/apm-managed-service/actions/runs/7858017783/job/21442506285

Details

This change sets apm/http as the default in the loadgen config.

Workflow run

Verified to work in https://github.com/elastic/apm-managed-service/actions/runs/7862337046/job/21451692616

@reakaleek reakaleek requested a review from a team as a code owner February 11, 2024 09:25
@reakaleek reakaleek requested a review from endorama February 11, 2024 09:27
@reakaleek reakaleek self-assigned this Feb 11, 2024
@reakaleek reakaleek requested a review from a team February 11, 2024 11:21
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe some other parts of the code were broken by #46

e.g.

func BenchmarkAgentAll(b *testing.B, l *rate.Limiter) {
	benchmarkAgent(b, l, `*.ndjson`)
}

func BenchmarkAgentGo(b *testing.B, l *rate.Limiter) {
	benchmarkAgent(b, l, `go*.ndjson`)
}

func BenchmarkAgentNodeJS(b *testing.B, l *rate.Limiter) {
	benchmarkAgent(b, l, `nodejs*.ndjson`)
}

func BenchmarkAgentPython(b *testing.B, l *rate.Limiter) {
	benchmarkAgent(b, l, `python*.ndjson`)
}

func BenchmarkAgentRuby(b *testing.B, l *rate.Limiter) {
	benchmarkAgent(b, l, `ruby*.ndjson`)
}

but the ndjson are renamed

@carsonip
Copy link
Member

I've proposed an alternative fix in #54. Let me know if it looks good.

@reakaleek
Copy link
Member Author

I've proposed an alternative fix in #54. Let me know if it looks good.

Thanks!

@reakaleek reakaleek closed this Feb 12, 2024
@reakaleek reakaleek deleted the feature/add-protocol-to-loadgen-config branch February 12, 2024 15:53
carsonip added a commit that referenced this pull request Feb 12, 2024
Fix regression caused by #46. Alternative to #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants