Fix empty api-keys option handling #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
approved these changes
Sep 28, 2023
| if len(kv) != 2 { | ||
| return nil, errors.New("invalid api keys provided. example: project_id:my_api_key") | ||
| if opts.APIKeys != "" { | ||
| pairs := strings.Split(opts.APIKeys, ",") |
There was a problem hiding this comment.
thought: I wonder if we could use strings.Cut and get rid of the two ifs.
There was a problem hiding this comment.
Not sure how that works to split by the : and eliminate the 2nd if. Also I think the current code's intention is very clear and shorter code isn't necessarily more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As strings.split("", ",") returns []string{""}, an empty api-keys option will cause apmsoak to throw "invalid api keys provided", effectively making api-keys a required option. Fix the handling to ignore empty api-keys.