Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle otlp semconv deployment.environment.name alongside deprecated deployment.environment #384

Merged
merged 1 commit into from
Oct 14, 2024

Handle otlp semconv deployment.environment.name

38c6dab
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Handle otlp semconv deployment.environment.name alongside deprecated deployment.environment #384

Handle otlp semconv deployment.environment.name
38c6dab
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Oct 14, 2024 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: 38c6dab

Base sha: ed18118

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 26990.6 1% 26742 3% ~ (p=0.452 n=5+5)
Encode/format=json-2 14192.2 6% 13776.6 2% -2.93% (p=0.032 n=5+5)
Encode/format=vtproto 4953.4 3% 5295.8 14% ~ (p=0.151 n=5+5)
Encode/format=vtproto-2 2967 14% 2815 3% ~ (p=0.690 n=5+5)
Decode/format=json 128467 1% 132852 6% +3.41% (p=0.016 n=5+5)
Decode/format=json-2 66969.5 1% 67739 2% ~ (p=0.063 n=4+5)
Decode/format=vtproto 20357.6 19% 18206.8 1% -10.57% (p=0.008 n=5+5)
Decode/format=vtproto-2 11052 6% 10736 3% ~ (p=0.310 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7592 0% 7592 0% ~ (all equal)
Encode/format=json-2 7593 0% 7593 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=json 14282.6 0% 14282 0% ~ (p=0.484 n=5+5)
Decode/format=json-2 14281.8 0% 14281.2 0% ~ (p=1.000 n=5+5)
Decode/format=vtproto 12952 0% 12952 0% ~ (all equal)
Decode/format=vtproto-2 12952 0% 12952 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 26 0% 26 0% ~ (all equal)
Encode/format=json-2 26 0% 26 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=json 379 0% 379 0% ~ (all equal)
Decode/format=json-2 379 0% 379 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 285.2 4% 278.6 0% ~ (p=0.190 n=5+4)
NDStreamDecoder-2 148.72 2% 149.66 3% ~ (p=1.000 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 16679 0% 15667.6 9% -6.06% (p=0.008 n=5+5)
APMEventToJSON/to-json-2 13315.8 1% 13049.6 1% -2.00% (p=0.008 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2616 0% 2616 0% ~ (all equal)
APMEventToJSON/to-json-2 2616 0% 2616 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 38 0% 38 0% ~ (all equal)
APMEventToJSON/to-json-2 38 0% 38 0% ~ (all equal)
View more details on GitHub Actions