Map updated HTTP server semantic conventions #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
commented
Apr 15, 2024
| @@ -450,11 +461,6 @@ func TranslateTransaction( | |||
| case semconv.AttributeRPCService: | |||
| case semconv.AttributeRPCMethod: | |||
|
|
|||
| // URL | |||
There was a problem hiding this comment.
Note for reviewer: The url.full attribute is not expected on spans for HTTP server requests, so I have removed this.
stevejgordon
force-pushed
the
enhancement/254-otelhttpserver
branch
from
72aae9c to
43892ab
Compare
|
@simitt Here's an initial stab at supporting the newer attributes. |
kruskall
approved these changes
Apr 15, 2024
|
I rebased onto main via the UI, which seems to have lost the signing on the commit, which is annoying. @kruskall Are there any alternatives to recommitting locally (with the signing) and force pushing? |
stevejgordon
force-pushed
the
enhancement/254-otelhttpserver
branch
from
43892ab to
91a6034
Compare
stevejgordon
force-pushed
the
enhancement/254-otelhttpserver
branch
from
91a6034 to
90fe722
Compare
|
@kruskall I rebased this onto the latest main. Would you mind re-reviewing and merging? I don't seem to have merge permissions in this repo. |
stevejgordon
force-pushed
the
enhancement/254-otelhttpserver
branch
from
90fe722 to
d5a3e7f
Compare
stevejgordon
force-pushed
the
enhancement/254-otelhttpserver
branch
from
d5a3e7f to
233bc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for updated semantic conventions for HTTP server spans.
Closes #254