Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for elastic.profiler_stack_trace_ids OTel attribute #202

Merged
merged 11 commits into from
Feb 7, 2024

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Jan 24, 2024

Closes #180 .
Maps the Otel attribute elastic.profiler_stack_trace_ids to the new ES field transaction.profiler_stack_trace_ids, which will use counted_keyword as type.

@JonasKunz JonasKunz marked this pull request as ready for review February 5, 2024 12:43
@JonasKunz JonasKunz requested a review from a team as a code owner February 5, 2024 12:43
kyungeunni
kyungeunni previously approved these changes Feb 7, 2024
Copy link
Contributor

@kyungeunni kyungeunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simitt
simitt previously approved these changes Feb 7, 2024
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment, otherwise LGTM

input/otlp/traces.go Show resolved Hide resolved
@carsonip carsonip self-requested a review February 7, 2024 10:03
input/otlp/traces.go Outdated Show resolved Hide resolved
@carsonip carsonip merged commit 668fa48 into elastic:main Feb 7, 2024
4 checks passed
@JonasKunz JonasKunz deleted the universal-profiling-integration branch February 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map and store profiling stacktrace IDs on transactions
4 participants