Fix otlp consumer interface; Add otlp partial success error message #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
previously approved these changes
Oct 18, 2023
…-data into fix-otlp-consumer-interface
carsonip
commented
Oct 18, 2023
| return ConsumeMetricsResult{ | ||
| RejectedDataPoints: remainingDataPoints, | ||
| ErrorMessage: errMsg, |
There was a problem hiding this comment.
Overloading this PR to add one missing element in #156 , which is to return an error message along with the rejected count. According to the spec, it MUST return a rejected count and SHOULD return a message. For the sake of simplicity and that we do not have any guarantees about the stability of the Consume*WithResult interface, we'll just have a string in Consume*Result struct instead of private fields + public methods.
In reality, currently, this ErrorMessage field is only non-empty when metrics rejected count > 0. The "unsupported data points" is not extremely helpful, but still better than nothing.
3 tasks
axw
approved these changes
Oct 19, 2023
carsonip
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#156 broke the otlp consumer interface. Fix it and add tests.