Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add callback option to config to capture context when starting transactions and spans #1525

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cjr125
Copy link

@cjr125 cjr125 commented Aug 23, 2024

No description provided.

Copy link

cla-checker-service bot commented Aug 23, 2024

💚 CLA has been signed

@cjr125 cjr125 force-pushed the review/captureStackTrace branch 2 times, most recently from ed422b7 to 18b404e Compare August 23, 2024 14:50
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whats the use-case we are solving with this. Why not use Global Labels for this functionality - https://www.elastic.co/guide/en/apm/agent/rum-js/current/agent-api.html#apm-add-labels

@cjr125
Copy link
Author

cjr125 commented Sep 10, 2024

Not sure whats the use-case we are solving with this. Why not use Global Labels for this functionality - https://www.elastic.co/guide/en/apm/agent/rum-js/current/agent-api.html#apm-add-labels

The specific use case for the callback is to capture context specific data which is different between the call stacks when firing / handling the transaction / span events from the auto-instrumentation. For example, when an application uses a combination of javascript files in which some import the RUM agent and others do not, there will be different stack traces when comparing the stack frame where the event was fired as opposed to handled. The ultimate goal would still be to assign labels, the gap being the context when the event is fired in cases where that context does not import the RUM agent library

@cjr125
Copy link
Author

cjr125 commented Sep 19, 2024

@vigneshshanmugam any update on this? do you understand the use case?

@cjr125 cjr125 force-pushed the review/captureStackTrace branch 3 times, most recently from 35de72c to 152babf Compare September 22, 2024 14:50
@cjr125 cjr125 force-pushed the review/captureStackTrace branch from 152babf to 88b2c85 Compare September 23, 2024 13:57
@malek-andrew
Copy link

@vigneshshanmugam Customer filed a support case today regarding this PR. Would you mind give it another review?

@cjr125 cjr125 force-pushed the review/captureStackTrace branch from 313f130 to d0e19bc Compare December 4, 2024 20:16
@cjr125 cjr125 force-pushed the review/captureStackTrace branch from d0e19bc to e13e428 Compare December 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants