-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add callback option to config to capture context when starting transactions and spans #1525
base: main
Are you sure you want to change the base?
Conversation
💚 CLA has been signed |
ed422b7
to
18b404e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whats the use-case we are solving with this. Why not use Global Labels for this functionality - https://www.elastic.co/guide/en/apm/agent/rum-js/current/agent-api.html#apm-add-labels
The specific use case for the callback is to capture context specific data which is different between the call stacks when firing / handling the transaction / span events from the auto-instrumentation. For example, when an application uses a combination of javascript files in which some import the RUM agent and others do not, there will be different stack traces when comparing the stack frame where the event was fired as opposed to handled. The ultimate goal would still be to assign labels, the gap being the context when the event is fired in cases where that context does not import the RUM agent library |
@vigneshshanmugam any update on this? do you understand the use case? |
35de72c
to
152babf
Compare
…transactions and spans
152babf
to
88b2c85
Compare
@vigneshshanmugam Customer filed a support case today regarding this PR. Would you mind give it another review? |
313f130
to
d0e19bc
Compare
d0e19bc
to
e13e428
Compare
No description provided.