Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace context in Sidekiq to connect request transaction and worker in the one trace #1456

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dixent
Copy link

@dixent dixent commented May 10, 2024

What does this pull request do?

  1. Adding transaction trace context in the Sidekiq job.
  2. Use transaction trace context when creating transactions for Sidekiq job by the Sidekiq server.

Why is it important?

Connection of transactions in one trace is necessary to display data in Kibana. It allows jumping from one transaction to another even if one worker calls another.

image

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

https://discuss.elastic.co/t/distributed-traces-on-background-jobs/256555

Copy link

cla-checker-service bot commented May 10, 2024

💚 CLA has been signed

@dixent dixent changed the title [WIP] Add trace context in Sidekiq to connect request transaction and worker in the one trace Add trace context in Sidekiq to connect request transaction and worker in the one trace May 10, 2024
@dixent
Copy link
Author

dixent commented May 16, 2024

I am sorry, I am waiting assist from my company management regarding CLA.

@dixent
Copy link
Author

dixent commented Jun 11, 2024

Ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant