build: bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.4.0 #3898
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [org.springframework.boot:spring-boot-dependencies](https://github.com/spring-projects/spring-boot) from 2.7.16 to 3.4.0. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.7.16...v3.4.0) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-dependencies dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
| @@ -430,7 +431,12 @@ private static ConstantCallSite internalBootstrap(MethodHandles.Lookup lookup, S | |||
| // avoid re-entrancy and stack overflow errors | |||
| // may happen when bootstrapping an instrumentation that also gets triggered during the bootstrap | |||
| // for example, adding correlation ids to the thread context when executing logger.debug. | |||
| logger().warn("Nested instrumented invokedynamic instruction linkage detected", new Throwable()); | |||
| if (!loggingForNestedCall.isNestedCallAndIncrement()) { | |||
There was a problem hiding this comment.
This caused the tests to timeout due to not making progress. This only happens due to our test instrumentation where instrument java.lang.System to return custom environment variable values.
|
|
||
| } else if (exchangeRequest instanceof ServerHttpRequestDecorator) { |
There was a problem hiding this comment.
Looks like this was a case we simply missed before. Starting with spring 3.4.0 the requests seem to be wrapped by some firewall by default.
| @@ -202,7 +202,7 @@ private Predicate<Throwable> expectClientError(int expectedStatus) { | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @CsvSource({"GET", "POST", "PUT", "DELETE", "PATCH", "HEAD", "OPTIONS", "TRACE"}) | |||
| @CsvSource({"GET", "POST", "PUT", "DELETE", "PATCH", "HEAD", "OPTIONS"}) | |||
There was a problem hiding this comment.
Looks like in spring 3.4.0 the TRACE method is now rejected by default with 400 BAD_REQUEST. TBH I've so far never seen the TRACE method used in the wild, so imo it is okay to simply remove it from the tests.
JonasKunz
deleted the
dependabot/maven/org.springframework.boot-spring-boot-dependencies-3.4.0
branch
Bumps org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.4.0.
Release notes
Sourced from org.springframework.boot:spring-boot-dependencies's releases.
... (truncated)
Commits
8964203Release v3.4.0109e731Revert "Add@ConditionalOnMissingBeanforJobRepository"d21952dMerge branch '3.3.x'4151938Next development version (v3.3.7-SNAPSHOT)14989a5Upgrade to Testcontainers 1.20.4c188822Upgrade to Spring Security 6.4.1e286739Upgrade to Spring Batch 5.2.073fc351Add@ConditionalOnMissingBeanforJobRepository3cae5c2Merge branch '3.3.x'283bc6fMerge branch '3.2.x' into 3.3.xDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)