Fix agent downloader with new signing key for 1.46.0 #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
changed the title
SylvainJuge
commented
Feb 5, 2024
|
|
||
| private static byte[] toByteArray(InputStream inputStream, int size) throws IOException { | ||
| byte[] result = new byte[size]; | ||
| if (size == 0 || size != inputStream.read(result) || inputStream.read() >= 0) { |
There was a problem hiding this comment.
[for reviewer] we can get away without a loop here as the content has known size and is rather small (less than 1kb).
| @@ -36,6 +41,7 @@ | |||
|
|
|||
| class AgentDownloaderTest { | |||
|
|
|||
| // valid key stored in valid_key.asc, but not the one used to sign agent artifacts | |||
There was a problem hiding this comment.
[for reviewer] here we need to have a valid GPG key.
JonasKunz
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The signing key for deployed artifacts in maven central has changed, so we need to update the Key ID and public key used for validation.
Apart from breaking unit tests, this only impacts the agent downloader that attemps to validate the downloaded agent with an embedded copy of the public key and key ID.
So the 1.46.0 agent won't be able to download itself.
This fix adds support for multiple keys and embeds the new key.
Checklist