Use LRU cache for statement parser #3492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the caching for our Statement parsing with a simple LRU cache.
Previously we, used a bounded Map and made some exclusions to caching:
This could lead to edge cases where the caching is not effective, which we encountered with a user.
This PR switches to the same caching approach also used by the OTel-agent: Simply cache everything, but use a bounded LRU cache.
Checklist