Add db.statement and user attributes to OpenTelemetry Plugin #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parsing of db.statement and db.user attributes for OpenTelementy Plugin. This will allow users to write an own Elastic APM Plugin for a not yet supported database and also add the executed statement to the span (like with the supported DBs)
github-actions
bot
added
agent-java
community
|
👋 @Shaoranlaos Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
Shaoranlaos
changed the title
jackshirazi
previously approved these changes
Jan 5, 2024
JonasKunz
previously approved these changes
Jan 5, 2024
|
@Shaoranlaos please fix the conflicts |
Shaoranlaos
dismissed stale reviews from JonasKunz and jackshirazi
via
28b789d
jackshirazi
approved these changes
Jan 5, 2024
|
@elasticmachine run elasticsearch-ci/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parsing of db.statement and db.user attributes for OpenTelementy Plugin.
This will allow users to write an own Elastic APM Plugin for a not yet supported database and also add the executed statement to the span (like with the supported DBs)
What does this PR do?
Add the ability to set the database user and the executed statement via an APM plugin via the attributes (like db name and system).
Checklist
This is a bugfixI have updated CHANGELOG.asciidocI have added tests that would fail without this fixThis is a new pluginI have updated CHANGELOG.asciidocMy code follows the style guidelines of this projectI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesI have updated supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introducedAdded an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.This is something elseI have updated CHANGELOG.asciidoc