fix span stacktrace capture #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
commented
Dec 21, 2023
Comment on lines
+169
to
+172
| assertThat(Arrays.stream(stackTrace.getStackTrace()).filter(stackTraceElement -> | ||
| stackTraceElement.getMethodName().equals("stackTraceEndSpan") | ||
| && stackTraceElement.getClassName().equals(ElasticApmTracerTest.class.getName()))).hasSize(1); | ||
| } |
There was a problem hiding this comment.
[for reviewer] this test does not actually check that the bugfix is effective, but just improves a bit the heuristic because until now there was none.
JonasKunz
previously approved these changes
Dec 22, 2023
JonasKunz
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Span stack trace is captured when the span ends, currently when the span is reported to the tracer. This implementation worked well until the introduction of compressed spans because the call to
ElasticApmTracer.report(Span)was synchronous.However, with the addition of compressed spans now the calls to
ElasticApmTracer.report(...)can happen while the compression algorithm is executed, thus after the span has already been ended. As a consequence, the captured stack trace needs to be captured when the span ends and not when it's reported.Checklist