Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support no secrets for dependabot #3473

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 20, 2023

What does this PR do?

Exclude dependabot from running the JBoss specific CI thing.
Retry if failures when pulling docker images - to add more resilience.

dependabot does not allow the use of secrets if those secrets are not defined in the dependabot secret section in GitHub. See dependabot/dependabot-core#3253

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@v1v v1v requested a review from a team December 20, 2023 18:14
@v1v v1v self-assigned this Dec 20, 2023
@v1v v1v requested a review from a team December 20, 2023 19:51
@v1v v1v merged commit f1c5748 into main Dec 21, 2023
14 checks passed
@v1v v1v deleted the feature/exclude-for-dependabot branch December 21, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants