Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ITs): support JBoss ITs with GitHub secrets #3469

Merged
merged 16 commits into from
Dec 20, 2023
Merged

ci(ITs): support JBoss ITs with GitHub secrets #3469

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
18c0851
ci(ITs): support JBoss ITs with GitHub secrets
v1v Dec 18, 2023
78d8851
Similarly done in https://github.com/elastic/apm-agent-dotnet/pull/2128
v1v Dec 18, 2023
bf2b2a9
isolate jboss integ test in a profile
SylvainJuge Dec 18, 2023
7ad36ff
use jboss CI profile name consistent with others
SylvainJuge Dec 18, 2023
db10b31
test newer and older jboss versions
SylvainJuge Dec 20, 2023
78ca4e8
Merge branch 'main' of github.com:elastic/apm-agent-java into feature…
SylvainJuge Dec 20, 2023
9ddf041
Pull docker images from the internal docker registry
v1v Dec 20, 2023
0b727b3
add latest jboss version just in case
SylvainJuge Dec 20, 2023
233a6cb
use full docker name
v1v Dec 20, 2023
3dd28a1
Merge branch 'feature/run-jboss' of https://github.com/elastic/apm-ag…
v1v Dec 20, 2023
a9c70cf
fix name
v1v Dec 20, 2023
3561de6
ci: groups
v1v Dec 20, 2023
d802890
avoid empty lines and group by when running on the CI
v1v Dec 20, 2023
2844216
limit test execution to it/jboss
SylvainJuge Dec 20, 2023
bd5bb7a
update documentation
SylvainJuge Dec 20, 2023
d7a68eb
add missing top-level profile for jboss exclusions
SylvainJuge Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,3 +320,33 @@ jobs:
path: |
**/junit-*.xml
**/TEST-*.xml

jboss:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] we could make that step a sub-step of the application server tests,but as it's quite fast (about 6min) in CI that's fine for now and allows us to keep an eye on it for now in case of failure.

name: JBoss integration tests
runs-on: ubuntu-latest
needs: build
if: github.event_name != 'pull_request' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only happen when a non-forked pull request.

steps:
- uses: actions/checkout@v4
- uses: elastic/apm-pipeline-library/.github/actions/docker-login@current
with:
registry: docker.elastic.co
secret: secret/observability-team/ci/docker-registry/prod
url: ${{ secrets.VAULT_ADDR }}
roleId: ${{ secrets.VAULT_ROLE_ID }}
secretId: ${{ secrets.VAULT_SECRET_ID }}
- uses: ./.github/workflows/unstash
with:
name: build
path: ${{ github.workspace }}
- uses: ./.github/workflows/maven-goal
with:
command: ./mvnw -q -P jboss-tests verify
- name: Store test results
if: success() || failure()
uses: actions/upload-artifact@v3
with:
name: test-results
path: |
**/junit-*.xml
**/TEST-*.xml
Loading