Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in api-opentelemetry.asciidoc #3448

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

fml2
Copy link

@fml2 fml2 commented Nov 30, 2023

What does this PR do?

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

Copy link

cla-checker-service bot commented Nov 30, 2023

💚 CLA has been signed

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Nov 30, 2023
Copy link

👋 @fml2 Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@SylvainJuge SylvainJuge removed the triage label Dec 4, 2023
@SylvainJuge
Copy link
Member

@fml2 Thanks a lot for your contribution, as this was already reviewed and approved, all you have left is to sign the CLA before we can merge this.

@fml2
Copy link
Author

fml2 commented Dec 4, 2023

I can't get through the procedure. I seem to accomplish it but it does not work. Feel free to just make those changes yourself.

@SylvainJuge
Copy link
Member

Thanks @fml2 it seems you have properly done it, so maybe there was a glitch and the CLA check is OK, which means we can merge.

@SylvainJuge SylvainJuge merged commit 388a1a0 into elastic:1.x Dec 5, 2023
5 checks passed
@fml2 fml2 deleted the patch-1 branch December 5, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants