Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test to verify the instrumentation support for the Spring HTTP client RestClient. #3442

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

videnkz
Copy link
Contributor

@videnkz videnkz commented Nov 27, 2023

What does this PR do?

Added a test to verify the instrumentation support for the Spring HTTP client RestClient.

closes #3441

Checklist

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Nov 27, 2023
Copy link

👋 @videnkz Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@videnkz videnkz changed the title ADded tests that checks spring RestClient Added a test to verify the instrumentation support for the Spring HTTP client RestClient. Nov 27, 2023
@videnkz videnkz marked this pull request as ready for review November 27, 2023 11:05
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
import static org.assertj.core.api.Assertions.assertThat;

public class SprintRestClientIntegration extends AbstractInstrumentationTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test bring any benefit In addition to the SpringRestClientInstrumentationTest? To me it seems like they cover the same things.

If it doesn't cover anything I'm missing here, let's keep it simple and remove SpringRestClientIntegration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@JonasKunz
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

JonasKunz
JonasKunz previously approved these changes Nov 28, 2023
Copy link
Contributor

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

jackshirazi
jackshirazi previously approved these changes Nov 28, 2023
@videnkz videnkz dismissed stale reviews from jackshirazi and JonasKunz via 923899a November 28, 2023 11:00
Copy link

cla-checker-service bot commented Nov 28, 2023

💚 CLA has been signed

@JonasKunz
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@JonasKunz JonasKunz merged commit 8ef5bf9 into elastic:main Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring Framework 6.1 - Add support for RestClient
3 participants