-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a test to verify the instrumentation support for the Spring HTTP client RestClient. #3442
Conversation
👋 @videnkz Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo; | ||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
public class SprintRestClientIntegration extends AbstractInstrumentationTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test bring any benefit In addition to the SpringRestClientInstrumentationTest
? To me it seems like they cover the same things.
If it doesn't cover anything I'm missing here, let's keep it simple and remove SpringRestClientIntegration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@elasticmachine run elasticsearch-ci/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this!
💚 CLA has been signed |
923899a
to
e578892
Compare
@elasticmachine run elasticsearch-ci/docs |
What does this PR do?
Added a test to verify the instrumentation support for the Spring HTTP client
RestClient
.closes #3441
Checklist
I have updated CHANGELOG.asciidoc