extend InstrumentationTest timeout to reduce flakeyness #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine run elasticsearch-ci/docs |
SylvainJuge
approved these changes
Nov 23, 2023
| @@ -421,7 +421,8 @@ void testPluginClassLoaderGCdAfterUndoingInstrumentation() { | |||
| await().untilAsserted(() -> assertThat(pluginClassLoader.get()).isNull()); | |||
| } | |||
|
|
|||
| @Test | |||
| //this is failing from unspecified - likely metaspace specific GC not happening - in CI | |||
| // @Test | |||
There was a problem hiding this comment.
[minor] maybe better to use @Ignore here, and keep the comment so we have a clue about the reason it's disabled.
Comment on lines
+445
to
+448
| long start = System.currentTimeMillis(); | ||
| while(System.currentTimeMillis()-start < 10_000) { | ||
|
|
||
| } |
There was a problem hiding this comment.
[minor] let's remove this if we disable the test for now.
jackshirazi
added a commit
to jackshirazi/apm-agent-java
that referenced
this pull request
Nov 23, 2023
videnkz
pushed a commit
to videnkz/apm-agent-java
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
lots of tests are hitting a timeout on InstrumentationTest but it's passing fine when run manually.
In the end I commented out the test. It's odd that it's started happening but there is no guarantee that the class will be unloaded in any time period, I think I'd have to set metaspace to some small value and it's easier to just stop doing the test