Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): use the new argument #3435

Merged
merged 1 commit into from
Nov 27, 2023
Merged

ci(release): use the new argument #3435

merged 1 commit into from
Nov 27, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 22, 2023

What does this PR do?

Use pipelineCommit rather than pipelineVersion which was is deprecated

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@v1v v1v requested review from a team November 22, 2023 11:10
@v1v v1v self-assigned this Nov 22, 2023
v1v
v1v commented Nov 22, 2023
View reviewed changes
.github/workflows/release.yml
@@ -100,7 +100,7 @@ jobs:
vaultRoleId: ${{ secrets.VAULT_ROLE_ID }}
vaultSecretId: ${{ secrets.VAULT_SECRET_ID }}
pipeline: apm-agent-java-release
pipelineVersion: ${{ env.TAG_NAME }}
pipelineCommit: ${{ env.TAG_NAME }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a regression. Though elastic/apm-pipeline-library#2450 will fix it and make the default behaviour with a higher precedence.

@v1v
Copy link
Member Author

v1v commented Nov 22, 2023

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2023

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]
  • -conflict [:pushpin: update requirement]

@v1v
Copy link
Member Author

v1v commented Nov 22, 2023

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2023

rebase

✅ Nothing to do for rebase action

@jackshirazi
Copy link
Contributor

https://github.com/Mergifyio rebase

@v1v @jackshirazi
ci(release): use the new argument
b27e23d 
pipelineVersion is deprecated
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

rebase

✅ Branch has been successfully rebased

@jackshirazi jackshirazi force-pushed the feature/action-use-new-argument branch from d2377cc to b27e23d Compare November 23, 2023 09:19
@v1v v1v merged commit dff526c into elastic:main Nov 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackshirazi jackshirazi jackshirazi approved these changes

@amannocci amannocci amannocci approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
agent-java
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @jackshirazi @kuisathaverat @amannocci