Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process otel benchmark #3384

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Process otel benchmark #3384

merged 3 commits into from
Oct 26, 2023

Conversation

jackshirazi
Copy link
Contributor

What does this PR do?

Associated to #3369 this processes the benchmark output and converts it to JSON suitable for ingestion to Elasticsearch

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@jackshirazi jackshirazi mentioned this pull request Oct 25, 2023
Closed
@jackshirazi jackshirazi marked this pull request as ready for review October 25, 2023 18:14
@jackshirazi jackshirazi requested a review from a team October 25, 2023 22:24
@jackshirazi jackshirazi merged commit d49065d into elastic:main Oct 26, 2023
v1v added a commit that referenced this pull request Oct 26, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/support-ben…
04041aa 
…chmark-otel-in-buildkite

* upstream/main:
  Process otel benchmark (#3384)
  Update tests for Jedis 5 (#3382)
  added entry to community plugins (#3383)
  added capturing s3 otel attributes from lamba S3Event (#3364)
  Bump version.log4j from 2.12.4 to 2.21.0 (#3366)
  Fix aws sdk instrumentation (#3373)
v1v added a commit to v1v/apm-agent-java that referenced this pull request Oct 27, 2023
@v1v
Merge branch 'main' of https://github.com/elastic/apm-agent-java
6d452fa 
* 'main' of https://github.com/elastic/apm-agent-java: (35 commits)
  buildkite: opentelemetry+elastic agent overhead benchmark on a weekly basis (elastic#3371)
  ci(action): remove unrequired action (elastic#3387)
  Bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.1.5 (elastic#3380)
  ci(action): archive benchmarks.jar (elastic#3386)
  remove noise (elastic#3385)
  Process otel benchmark (elastic#3384)
  Update tests for Jedis 5 (elastic#3382)
  added entry to community plugins (elastic#3383)
  added capturing s3 otel attributes from lamba S3Event (elastic#3364)
  Bump version.log4j from 2.12.4 to 2.21.0 (elastic#3366)
  Fix aws sdk instrumentation (elastic#3373)
  action: remove leftover from Jenkins (elastic#3368)
  Bump org.apache.logging.log4j:log4j-bom from 2.20.0 to 2.21.0 (elastic#3367)
  Bump io.micrometer:micrometer-core from 1.11.4 to 1.11.5 (elastic#3360)
  Add guard against invalid end timestamps (elastic#3363)
  Added otel to dependabot config, upgraded dependencies (elastic#3359)
  Bump version.byte-buddy from 1.14.8 to 1.14.9 (elastic#3361)
  Fix off-by-one error in tests which effectively disabled recycling validation (elastic#3357)
  Fix multiple spans being created for HTTPUrlConnection HEAD requests (elastic#3353)
  Bump org.ow2.asm:asm-tree from 9.5 to 9.6 (elastic#3349)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKunz JonasKunz JonasKunz approved these changes

Assignees
No one assigned
Labels
agent-java
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackshirazi @JonasKunz