buildkite: opentelemetry+elastic agent overhead benchmark on a weekly basis #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
v1v
changed the title
v1v
commented
Oct 18, 2023
| @@ -1,4 +1,5 @@ | |||
| # @reakaleek: This is a place holder to create the pipeline in Buildkite. I will work on it, in a follow-up. | |||
There was a problem hiding this comment.
unrequired, only for testing purposes
v1v
commented
Oct 18, 2023
v1v
commented
Oct 18, 2023
v1v
commented
Oct 18, 2023
…value from the environment.
so there is no need to built from sources but use the latest one
jackshirazi
reviewed
Oct 26, 2023
jackshirazi
reviewed
Oct 26, 2023
jackshirazi
reviewed
Oct 26, 2023
v1v
commented
Oct 26, 2023
| @@ -122,7 +122,7 @@ private void writeBulkFile(String resultFilePath) throws IOException { | |||
| final File file = new File(resultFilePath); | |||
| final FileWriter fileWriter = new FileWriter(file); | |||
| for (JsonNode benchmark : bechmarkResultJson) { | |||
| fileWriter.append("{ \"index\" : { \"_index\" : \"microbenchmarks\" } }\n"); | |||
| fileWriter.append("{ \"index\" : { \"_index\" : \"otel-microbenchmarks\" } }\n"); | |||
There was a problem hiding this comment.
This should help with using a specific index for this kind of overhead-benchmark. If the name of the index changes then it requires also changes in the elasticsearch role - so it can write to that particular new index.
Co-authored-by: jackshirazi <[email protected]>
…/github.com/v1v/apm-agent-java into feature/support-benchmark-otel-in-buildkite * 'feature/support-benchmark-otel-in-buildkite' of https://github.com/v1v/apm-agent-java: chore: more log groups to help with printing output common steps buildkite: notify in the channel run gh within the apm-agent-java context avoid login avoid load pipeline using pre-command fixes: To have GitHub CLI store credentials instead, first clear the value from the environment. improve: use gh and clone main with shallow cloning Update .buildkite/scripts/opentelemetry-benchmark.sh no retry chore: for testing purposes buildkite: run opentelemetry benchmark
…/github.com/elastic/apm-agent-java into feature/support-benchmark-otel-in-buildkite * 'feature/support-benchmark-otel-in-buildkite' of https://github.com/elastic/apm-agent-java: Apply suggestions from code review consume github action artifact enable send benchmark feat: change index name chore chore: log reduce log levels for the maven thing fix: env variable and use the relative path to the jar file support generate ES docs chore: change logs add apm-server mock and tear down buildkite: prepare ES credentials use markdown format and add entry for reporting output buildkite: archive report buildkite: use annotations to visualise report
v1v
commented
Oct 26, 2023
...ent-benchmarks/src/main/java/co/elastic/apm/agent/benchmark/ProcessOtelBenchmarkResults.java
Outdated
Show resolved
Hide resolved
v1v
commented
Oct 26, 2023
jackshirazi
approved these changes
Oct 27, 2023
v1v
added a commit
to v1v/apm-agent-java
that referenced
this pull request
Oct 27, 2023
* 'main' of https://github.com/elastic/apm-agent-java: (35 commits) buildkite: opentelemetry+elastic agent overhead benchmark on a weekly basis (elastic#3371) ci(action): remove unrequired action (elastic#3387) Bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.1.5 (elastic#3380) ci(action): archive benchmarks.jar (elastic#3386) remove noise (elastic#3385) Process otel benchmark (elastic#3384) Update tests for Jedis 5 (elastic#3382) added entry to community plugins (elastic#3383) added capturing s3 otel attributes from lamba S3Event (elastic#3364) Bump version.log4j from 2.12.4 to 2.21.0 (elastic#3366) Fix aws sdk instrumentation (elastic#3373) action: remove leftover from Jenkins (elastic#3368) Bump org.apache.logging.log4j:log4j-bom from 2.20.0 to 2.21.0 (elastic#3367) Bump io.micrometer:micrometer-core from 1.11.4 to 1.11.5 (elastic#3360) Add guard against invalid end timestamps (elastic#3363) Added otel to dependabot config, upgraded dependencies (elastic#3359) Bump version.byte-buddy from 1.14.8 to 1.14.9 (elastic#3361) Fix off-by-one error in tests which effectively disabled recycling validation (elastic#3357) Fix multiple spans being created for HTTPUrlConnection HEAD requests (elastic#3353) Bump org.ow2.asm:asm-tree from 9.5 to 9.6 (elastic#3349) ...
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run the opentelemetry+elastic for the latest success build in
mainon weekly basis.For such it uses the existing micro-benchmarks runners that are available in Buildkite.
Part of #3369
Test
This Buildkite build produced:
Checklist