Fix multiple spans being created for HTTPUrlConnection HEAD requests #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
added
the
ci:jdk-compatibility
SylvainJuge
approved these changes
Oct 10, 2023
| @Advice.Origin String signature) { | ||
|
|
||
| //With HEAD requests the connected stays false |
There was a problem hiding this comment.
[minor] that's really an implementation detail here, could we also check the HTTP verb to be sure ?
There was a problem hiding this comment.
I'd argue that even for non-HEAD requests this approach is safer: If a responseCode is available, this implies that the connection has already been made. Therefore I think an additional check would not be good here.
There was a problem hiding this comment.
Good for me, let's keep it as-is then !
|
@Mergifyio refresh |
✅ Pull request refreshed |
schikin
pushed a commit
to schikin/apm-agent-java
that referenced
this pull request
Oct 11, 2023
…lastic#3353) * Fix multiple spans being created for HTTPUrlConnection HEAD requests * Added changelog --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
v1v
added a commit
to v1v/apm-agent-java
that referenced
this pull request
Oct 27, 2023
* 'main' of https://github.com/elastic/apm-agent-java: (35 commits) buildkite: opentelemetry+elastic agent overhead benchmark on a weekly basis (elastic#3371) ci(action): remove unrequired action (elastic#3387) Bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.1.5 (elastic#3380) ci(action): archive benchmarks.jar (elastic#3386) remove noise (elastic#3385) Process otel benchmark (elastic#3384) Update tests for Jedis 5 (elastic#3382) added entry to community plugins (elastic#3383) added capturing s3 otel attributes from lamba S3Event (elastic#3364) Bump version.log4j from 2.12.4 to 2.21.0 (elastic#3366) Fix aws sdk instrumentation (elastic#3373) action: remove leftover from Jenkins (elastic#3368) Bump org.apache.logging.log4j:log4j-bom from 2.20.0 to 2.21.0 (elastic#3367) Bump io.micrometer:micrometer-core from 1.11.4 to 1.11.5 (elastic#3360) Add guard against invalid end timestamps (elastic#3363) Added otel to dependabot config, upgraded dependencies (elastic#3359) Bump version.byte-buddy from 1.14.8 to 1.14.9 (elastic#3361) Fix off-by-one error in tests which effectively disabled recycling validation (elastic#3357) Fix multiple spans being created for HTTPUrlConnection HEAD requests (elastic#3353) Bump org.ow2.asm:asm-tree from 9.5 to 9.6 (elastic#3349) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While testing with a local spring-boot app I noticed that out instrumentation created 14 spans per single RestTemplate request.
This issue occured because I instructed the
RestTemplateto ignore the response body by setting the expected type toVoid.class. This causes spring to sendHEADrequests instead. And as it turns out, ourHTTPUrlConnectioninstrumentation doesn't deal well with those:The internal
connectedfield is not switched totrueforHEADrequests, causing multiple spans to be created when invokinggetResponseCodemultiple times.This PR fixes this by also checking the
responseCodefield to infer whether theHTTPUrlConnectionhas already connected or not.Checklist