minor code changes

elastic · Feb 1, 2024 · f9cd0ce · f9cd0ce
1 parent 3e44106
commit f9cd0ce
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/...agent-plugins/apm-jmx-plugin/src/main/java/co/elastic/apm/agent/jmx/JmxMetricTracker.java b/...agent-plugins/apm-jmx-plugin/src/main/java/co/elastic/apm/agent/jmx/JmxMetricTracker.java
@@ -355,15 +355,14 @@ private static String metricPrepend(Labels labels) {
         return "";
     }
 
-    private static void addJmxMetricRegistration(JmxMetric jmxMetric, List<JmxMetricRegistration> registrations, ObjectName objectName, Object value, JmxMetric.Attribute attribute, String attributeName, String metricPrepend) throws AttributeNotFoundException {
+    private static void addJmxMetricRegistration(JmxMetric jmxMetric, List<JmxMetricRegistration> registrations, ObjectName objectName, Object value, JmxMetric.Attribute attribute, String attributeName, @Nullable String metricPrepend) throws AttributeNotFoundException {
+        String effectiveAttributeName = metricPrepend == null ? attributeName : metricPrepend + attributeName;
         if (value instanceof Number) {
             logger.debug("Found number attribute {}={}", attribute.getJmxAttributeName(), value);
             registrations.add(
                 new JmxMetricRegistration(
                     attribute.getMetricName(
-                        metricPrepend == null ?
-                            attributeName :
-                            metricPrepend + attributeName
+                        effectiveAttributeName
                     ),
                     attribute.getLabels(objectName),
                     attributeName,
@@ -380,10 +379,7 @@ private static void addJmxMetricRegistration(JmxMetric jmxMetric, List<JmxMetric
                         new JmxMetricRegistration(
                             attribute.getCompositeMetricName(
                                 key,
-                                metricPrepend == null ?
-                                    attributeName :
-                                    metricPrepend + attributeName
-                            ),
+                                effectiveAttributeName),
                             attribute.getLabels(objectName),
                             attributeName,
                             key,
@@ -427,11 +423,13 @@ void register(final MBeanServer server, final MetricRegistry metricRegistry) {
                 @Override
                 public double get() {
                     try {
+                        double value;
                         if (compositeDataKey == null) {
-                            return ((Number) server.getAttribute(objectName, jmxAttribute)).doubleValue();
+                            value = ((Number) server.getAttribute(objectName, jmxAttribute)).doubleValue();
                         } else {
-                            return ((Number) ((CompositeData) server.getAttribute(objectName, jmxAttribute)).get(compositeDataKey)).doubleValue();
+                            value = ((Number) ((CompositeData) server.getAttribute(objectName, jmxAttribute)).get(compositeDataKey)).doubleValue();
                         }
+                        return value;
                     } catch (InstanceNotFoundException | AttributeNotFoundException e) {
                         unregister(metricRegistry);
                         return Double.NaN;