[script] [combat-trainer] Add spell selection criteria based on celestial objects (3 of 3) #7043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the plan here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6933 and #7039
Burn requires any moon or sun to be up to cast
Dazzle requires bright moon or sun to be cast
This is a part 3 of 3 changes to enable combat-trainer to cast burn/dazzle when it can, and another spell when it can't. Needs to be 3 changes due to how dr-scripts updates work.
Part 1 - new common methods
Part 2 - new data fields in base-spells on the two spells
Part 3 - update to combat-trainer (this change)