Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Script] [sorter] Rework of sorter to accept table arg #7027

Merged
merged 10 commits into from
Dec 18, 2024

Conversation

ThatRasputin
Copy link
Contributor

  • Reworked entire script to allow use of the 'terminal-table' gem
  • Added ability to call sorter with the arg 'table' to format output as a table using the gem
  • Made some changes to the old-school output of sorter, and left it as the default output
  • Assured it worked with looking on, behind, and under
  • Checked for use with various surfaces to ensure recognition

@ThatRasputin ThatRasputin changed the title Rework of sorter to accept table arg [Script][sorter] Rework of sorter to accept table arg Dec 17, 2024
@ThatRasputin ThatRasputin changed the title [Script][sorter] Rework of sorter to accept table arg [Script] [sorter] Rework of sorter to accept table arg Dec 17, 2024
@ThatRasputin
Copy link
Contributor Author

That was a harrowing journey. Everything should be clean now.

@MahtraDR
Copy link
Collaborator

Got some screenshots or some example changes?

@ThatRasputin
Copy link
Contributor Author

image
image
image

Retention of the current method as the default option:
image

@ThatRasputin
Copy link
Contributor Author

The next bit I'm working on is to tableify shop output with prices as part of it. I realize that is a little superfluous since it already outputs as lines, but sorting it into categories would be something I would like myself.

@MahtraDR
Copy link
Collaborator

This looks awesome. Thank you!

@MahtraDR MahtraDR merged commit 76796c3 into elanthia-online:main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants