-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Script] [sorter] Rework of sorter to accept table arg #7027
Merged
MahtraDR
merged 10 commits into
elanthia-online:main
from
ThatRasputin:script/update-sorter
Dec 18, 2024
Merged
[Script] [sorter] Rework of sorter to accept table arg #7027
MahtraDR
merged 10 commits into
elanthia-online:main
from
ThatRasputin:script/update-sorter
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThatRasputin
commented
Dec 16, 2024
- Reworked entire script to allow use of the 'terminal-table' gem
- Added ability to call sorter with the arg 'table' to format output as a table using the gem
- Made some changes to the old-school output of sorter, and left it as the default output
- Assured it worked with looking on, behind, and under
- Checked for use with various surfaces to ensure recognition
ThatRasputin
changed the title
Rework of sorter to accept table arg
[Script][sorter] Rework of sorter to accept table arg
Dec 17, 2024
ThatRasputin
changed the title
[Script][sorter] Rework of sorter to accept table arg
[Script] [sorter] Rework of sorter to accept table arg
Dec 17, 2024
…d a happy medium.
…e default output. Corrected.
That was a harrowing journey. Everything should be clean now. |
Got some screenshots or some example changes? |
The next bit I'm working on is to tableify shop output with prices as part of it. I realize that is a little superfluous since it already outputs as lines, but sorting it into categories would be something I would like myself. |
This looks awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.