Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script] [combat-trainer] Option for Bard cyclic to segue to on combat end instead of releasing #6937

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

hat071af
Copy link
Contributor

Adds an option for Bards to segue to a chosen cyclic spell when combat ends instead of releasing their cyclic. If the segue fails it will still release the original cyclic if it's not on the cyclic_no_release list.

These are the settings needed in your character yaml:

# Set a cyclic spell to segue to instead of releasing a cyclic when combat-trainer ends. 
# Bard only setting. Must know how to segue. 
# Strongly recommended to use a justice safe spell. Works best when using a spell from cyclic_no_release: 
# Use the cyclic spell abbrevation. E.g. botf. The segue parser doesn't like full spell names.
segue_spell_on_stop: botf
segue_prep_on_stop: 25

@MahtraDR
Copy link
Collaborator

This looks really neat. Sorry I missed it earlier. It does need those two settings in base-yaml.yaml blanked out though.

@hat071af
Copy link
Contributor Author

hat071af commented Oct 27, 2024

This looks really neat. Sorry I missed it earlier. It does need those two settings in base-yaml.yaml blanked out though.

Hrm. Can you elaborate/clarify? I tested it without them existing in either base.yaml and my character-setup.yaml and it just skips the 3 lines I added. I.e. segue_spell_on_stop doesn't exist so the if statement if DRStats.guild == "Bard" && @settings.segue_spell_on_stop returns false and it moves on to the usual release cyclic check.

I can add them to base.yaml if needed, though.

@MahtraDR
Copy link
Collaborator

This looks really neat. Sorry I missed it earlier. It does need those two settings in base-yaml.yaml blanked out though.

Hrm. Can you elaborate/clarify? I tested it without them existing in either base.yaml and my character-setup.yaml and it just skips the 3 lines I added. I.e. segue_spell_on_stop doesn't exist so the if statement if DRStats.guild == "Bard" && @settings.segue_spell_on_stop returns false and it moves on to the usual release cyclic check.

I can add them to base.yaml if needed, though.

Yes please add them. Weird, without them defined at all it should error, ah well. Good practices chug one! :)

@MahtraDR MahtraDR merged commit 380653c into elanthia-online:master Oct 29, 2024
2 checks passed
@MahtraDR
Copy link
Collaborator

Thanks!

@hat071af hat071af deleted the post-combat-segue branch October 30, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants