[script] [truffenyi-commune-quest] make truffenyi script more feature rich #6926
Conversation
… rich Handle solving the altar puzzle
drink the vial if you find it (with warning about how long this can take) otherwise assume it's already been drunk like before
some rubocop clean up
|
GTG even with rubocop warnings (most are indent issue which are present for better code collapse) |
|
GTG even with rubocop warnings (most are indent issue which are present for better code collapse) |
|
Can uuu you please do the rubocop autocorrects or propose a change to the rubocop rules? I accept the indentation folding idea, but rubocop keeps me sane too. |
|
IMO rubocop makes a good sniff test for happy flows - it catches a lot of 'oops' in those. But for unhappy flows it should be 'someone 4-eyes this', not as the final arbiter. If the committer can articulate a good justification for the ignoring it should be OK. Just my .02 *ETA: That said, I'll take a pass at inline rubocop directives explaining this in code. |
|
Given how messy this PR is with the commits, just ping me on discord if you're OK with how I've handled rubocop and I'll do another branch with a cleaner commit history for merging. |
|
This works for me. Thanks! |
Handle solving the altar puzzle
Slightly better vial handling
Handle the shrine/ox puzzle
Still will not find shrine for you