[scripts][sort-scrolls] adjust handling of scrolls with > 2 words in the adjective segment #6894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
three word scrolls were having parsing issues. unable to get `sanguine paper scroll`. scroll system puts it all into the 15 characters for adjective, so we can split and use the first + last to successfully grab. tested with various paper colors.
|
Sorry, I somehow missed this. Not all scrolls work with first + last. Have a look at https://github.com/rpherbig/dr-scripts/blob/aa4247d7c0c0cc47d5df4adfd16aab9f08e0a997/common.lic#L344 for examples. I'm happy to merge this if you want, just know it's not the full solution. |
|
What are we doing with this one? |
|
Closing MR, will look into common update vs script for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
three word scrolls were having parsing issues. unable to get
sanguine paper scroll. scroll system puts it all into the 15 characters for adjective, so we can split and use the first + last to successfully grab. tested with various paper colors.