-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts][alchemy] Improve foraged ingredient handling #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pause after putting foraged ingredient into herb storage container, to better prevent hitting RT. Changed from using "stow" ingredient to putting the ingredient in the desired crafting container. Stow was putting ingredients into other containers, causing issues with getting ingredients out again (particularly crushed vs uncrushed versions).
MahtraDR
changed the title
Improve foraged ingredient handling
[scripts][alchemy]Improve foraged ingredient handling
Jul 16, 2024
MahtraDR
changed the title
[scripts][alchemy]Improve foraged ingredient handling
[scripts][alchemy] Improve foraged ingredient handling
Jul 16, 2024
MahtraDR
reviewed
Jul 16, 2024
MahtraDR
reviewed
Jul 16, 2024
MahtraDR
reviewed
Jul 16, 2024
Added some comments. Try them out. I am reasonably sure they'll work. :) |
Co-authored-by: Mahtra <[email protected]>
Co-authored-by: Mahtra <[email protected]>
Co-authored-by: Mahtra <[email protected]>
Tested and works! Thanks for the suggestions for making it more foolproof! |
Added successful dissect message seen when dissecting telga orek.
This reverts commit 3023b5b.
Thank you for the submission!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pause after putting foraged ingredient into herb storage container, to better prevent hitting RT.
Changed from using "stow" ingredient to putting the ingredient in the desired crafting container. Stow was putting ingredients into other containers, causing issues with getting ingredients out again (particularly crushed vs uncrushed versions).