Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[script][base-spells]move php recast message to cast_messages #6858

Merged
merged 3 commits into from
Jul 7, 2024
Merged

[script][base-spells]move php recast message to cast_messages #6858

merged 3 commits into from
Jul 7, 2024

Conversation

desertkaz
Copy link
Contributor

Moved recast message for php to cast_messages
image
image

@desertkaz desertkaz changed the title Desertkaz patch 1 [base-spells][php-messaging]move recast message to cast_messages Jul 6, 2024
@desertkaz desertkaz changed the title [base-spells][php-messaging]move recast message to cast_messages [script][base-spells]move php recast message to cast_messages Jul 6, 2024
Kiriawen
Kiriawen suggested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@Kiriawen Kiriawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding line 265 why not adjust line 264 and just remove everything after the , so that the one line matches multiple messages

@MahtraDR MahtraDR merged commit 4268b82 into elanthia-online:master Jul 7, 2024
1 check passed
@desertkaz desertkaz deleted the desertkaz-patch-1 branch July 7, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiriawen Kiriawen Kiriawen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desertkaz @Kiriawen @MahtraDR