Update base-spells.yaml - added anti-magic room checks for invoke/charge/perc #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added matches for when invoking or charging cambrinth fails due to wild magic anti-magic room
…agic room Added match for when invoking a tattoo in a wild magic anti-magic room fails
…agic room Added a match for when the perc command fails in a wild magic anti-magic room
hat071af
changed the title
hat071af
changed the title
|
I'm happy to merge these, but I do also have a worry because these temporary changes to room magic mechanics will impact other scripts. This isn't inherently relevant to this PR though. Wand watcher and buff watcher for example will need to account for temporary anti-magic rooms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added matches for when invoking or charging cambrinth, perc, or invoking a tattoo fails due to wild magic anti-magic room