Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base-spells.yaml #6830

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Update base-spells.yaml #6830

merged 1 commit into from
Jun 3, 2024

Conversation

hat071af
Copy link
Contributor

@hat071af hat071af commented Jun 3, 2024

Added catch for case when using tattoo_tm: to target a tm spell after invoking it from a tattoo fails due to lack of target.

Added catch for case when using tattoo_tm: to target a tm spell after invoking it from a tattoo fails due to lack of target.
@MahtraDR
Copy link
Collaborator

MahtraDR commented Jun 3, 2024

Why the commented line?

@hat071af
Copy link
Contributor Author

hat071af commented Jun 3, 2024

I just copied the same bit from the cast_messages: section below to be consistent with the documentation there.

# You tried to cast an offensive spell and the target no longer exists
- There is nothing else to face 
# If don't know the cast command, like 'barrage'
- Please rephrase that command

I figure it should probably have some explanation why its there since it's a target command failure message in a list of messages related to the prepare command

@MahtraDR
Copy link
Collaborator

MahtraDR commented Jun 3, 2024

Ah so the line being added to the list is a snippet from the comment? Sorry that wasn't clear. If this is the case, please match case.

@hat071af
Copy link
Contributor Author

hat071af commented Jun 3, 2024

Uh, no? I'm not sure where the communication error is happening lol. The functional line being added is the in game output amd matches case. You asked why there was a commented line, and that's just for documentation and follows the convention of other documentation comments that already exist in the file.

@MahtraDR
Copy link
Collaborator

MahtraDR commented Jun 3, 2024

All good. I'll merge this and we fix whatever we have to later if we have to. 😀

@MahtraDR MahtraDR merged commit 03c6e24 into elanthia-online:master Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants