[scripts][workorders][data][base-recipes] fix for an issue with rod parts #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected an issue I (and others) have encountered since 2022 when logic to use existing materials for enchanting was added. After digging into it, the biggest source of the issue is that it was passing only the noun into DRCI.count_items_in_container, which prevented that method from checking for the full item name as it should. Additionally, rods were listed with only their partial name as parts in base-recipes. Finally, rods are listed with only their noun in base-crafting, but the script was passing the full name here.
I've tested with both a low and high level enchanter.
This fixes issue #6290