[scripts][go2] Re-supporting the ability to use spaces in custom go2 locations #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urbaj-dr
suggested changes
Mar 3, 2024
There was a problem hiding this comment.
I think that this change to the regex could allow for accidental duplicated custom targets, based on how go2 handles whitespace.
go2 save test=1901
go2 save test = 1900
These would get saved as "test" and "test ", and only "go2 test" [the target without a trailing space] would be navigable.
It's not a big problem, but stripping the whitespace on line 360 should solve it
target_name = $1.strip
|
Added in a strip per @urbaj-dr. Also, removed the extra space from my history comment to appease rubocop. |
MahtraDR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier commit removed the ability to use spaces as part of custom locations. This adds back in that ability.