[scripts][pick] Handle khri safe dodged failures #6757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old logic assumes that dodging a blown trap with Khri Safe fully disarms the box, and that it's ok to proceed with picking. This doesn't seem to be the case, e.g.: https://pastebin.com/iU5CpVSs From line 22 onward, all traps remain after dodging the failed disarm.
|
I don't like this change because it renders those two |
MahtraDR
reviewed
Feb 16, 2024
MahtraDR
changed the title
|
Merging in now, I'll own fixing if it screws something up. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic assumes that dodging a blown trap with Khri Safe fully disarms the box, and that it's ok to proceed with picking. This doesn't seem to be the case - see the attached log: khri_safe_dodge.txt
From line 22 onward, all traps remain after dodging the failed disarm.