task-forage #6700
Merged
task-forage #6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
task-forage completes foraging tasks from NPCs like Mags, primarily intended for Trading EXP. Supports Crossing (Mags) and Shard (flower peddler)
Contains room numbers for most known foraged items, particularly in Zoluren and Ilithi.
default settings for task-forage
Using correct rubocop settings
Raykyn55
reviewed
Sep 21, 2023
I really appreciate the thorough review. It's incredibly helpful to see someone else's perspective on my code, especially as I'm still fairly naive with Ruby. |
Don't sell yourself short, this is very good. All of my comments are style choices, not bad code. |
Incorporating Raykyn's suggestions from review
Raykyn55
reviewed
Sep 21, 2023
Refined boost logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-forage completes foraging tasks for Trading EXP from task givers in Crossing (Mags) and Shard (flower peddler). Similar to Magzon, but with some new features (more convenient locations, option to use BOOST TASK, use collect instead of forage, not sending people to die in storm bulls in search of tea leaves, etc.)